Include Pod OS field by ravisantoshgudimetla · Pull Request #35985 · kubernetes/website

ravisantoshgudimetla · 2022-08-15T16:21:09Z

Include Pod OS field in the pod concepts.

netlify · 2022-08-15T16:21:13Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`84da6bb`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6303ae35e26911000952cc2e

ravisantoshgudimetla · 2022-08-15T16:22:50Z

cc @sftim

sftim

Thanks for the PR. I have a few small suggestions that I hope make sense.

content/en/docs/concepts/workloads/pods/_index.md

sftim · 2022-08-15T16:31:29Z

/milestone 1.25

Relevant to kubernetes/enhancements#2802

ravisantoshgudimetla · 2022-08-15T17:32:07Z

The changes you made are correct @sftim. Thank you :)

marosset · 2022-08-15T18:08:39Z

content/en/docs/concepts/workloads/pods/_index.md

+
+{{< feature-state state="stable" for_k8s_version="v1.25" >}}
+
+You should set the `.spec.os.name` field to either `windows` or `linux` to indicate the OS on


nit:
Should this be 'To indicate the OS on which the pod is intended to run on, set the .spec.os.name field to either windows or linux. ?
This avoids language like should or can.

I like that we're making a recommendation. It's more than “there's this field, you could use it if you like”; now the field is GA, it's “you ought to set this field”.

If we had the capacity it'd be nice to show a sample webhook that produces a Warning when you don't set that for a Pod / pod template.

Given that there's System.Net.HttpListener, that sample webhook could even be written in PowerShell!

If we had the capacity it'd be nice to show a sample webhook that produces a Warning when you don't set that for a Pod / pod template.

We can do that but it is left to the user as an exercise since the use-cases may differ.

marosset · 2022-08-15T18:09:50Z

LGTM (from sig-windows)

jihoon-seo · 2022-08-16T09:12:53Z

/label tide/merge-method-squash

ravisantoshgudimetla · 2022-08-16T12:32:37Z

/retest

ravisantoshgudimetla · 2022-08-16T12:32:50Z

@sftim - Any other concerns here?

bradtopol · 2022-08-16T14:44:39Z

Assigning @sftim since he is already engaged on this.
/assign @sftim

marosset · 2022-08-17T16:02:21Z

@ravisantoshgudimetla can you take a look at the CI job failures?

jihoon-seo · 2022-08-19T01:05:52Z

@ravisantoshgudimetla to re-trigger Netlify build, you can (force-)push again.
For example, you might squash multiple commits into one single commit and then force-push.

sftim · 2022-08-19T07:30:43Z

I've triggered a new Netlify preview. No need to force-push a near identical commit in order to make that happen.

Include Pod OS field in the pod concepts.

reylejano · 2022-08-22T14:45:13Z

/approve

k8s-ci-robot · 2022-08-22T14:45:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [reylejano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sftim · 2022-08-22T16:24:46Z

/remove-label tide/merge-method-squash

content/en/docs/concepts/workloads/pods/_index.md

sftim

/lgtm

k8s-ci-robot · 2022-08-22T16:27:10Z

LGTM label has been added.

Details

Git tree hash: bf59892b3b9648959bb5132c5520d23bda7b16b4

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 15, 2022

ravisantoshgudimetla mentioned this pull request Aug 15, 2022

Promote PodOS field to GA #35590

Merged

k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 15, 2022

k8s-ci-robot requested review from divya-mohan0209 and tengqm August 15, 2022 16:21

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 15, 2022

sftim reviewed Aug 15, 2022

View reviewed changes

content/en/docs/concepts/workloads/pods/_index.md Show resolved Hide resolved

content/en/docs/concepts/workloads/pods/_index.md Outdated Show resolved Hide resolved

content/en/docs/concepts/workloads/pods/_index.md Outdated Show resolved Hide resolved

k8s-ci-robot added this to the 1.25 milestone Aug 15, 2022

sftim mentioned this pull request Aug 15, 2022

Identify Windows pods at API admission level authoritatively kubernetes/enhancements#2802

Closed

26 tasks

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 15, 2022

marosset reviewed Aug 15, 2022

View reviewed changes

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 16, 2022

k8s-ci-robot assigned sftim Aug 16, 2022

Include Pod OS field

5206c7f

Include Pod OS field in the pod concepts.

ravisantoshgudimetla force-pushed the pod-os branch from 2e122da to 5206c7f Compare August 22, 2022 13:21

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2022

k8s-ci-robot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 22, 2022

sftim reviewed Aug 22, 2022

View reviewed changes

content/en/docs/concepts/workloads/pods/_index.md Outdated Show resolved Hide resolved

Fix broken shortcode

84da6bb

sftim reviewed Aug 22, 2022

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2022

k8s-ci-robot merged commit 51b647b into kubernetes:dev-1.25 Aug 22, 2022


		{{< feature-state state="stable" for_k8s_version="v1.25" >}}

		You should set the `.spec.os.name` field to either `windows` or `linux` to indicate the OS on

Conversation

ravisantoshgudimetla commented Aug 15, 2022

Uh oh!

netlify bot commented Aug 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Uh oh!

ravisantoshgudimetla commented Aug 15, 2022

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sftim commented Aug 15, 2022

Uh oh!

ravisantoshgudimetla commented Aug 15, 2022

Uh oh!

marosset Aug 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sftim Aug 16, 2022

Choose a reason for hiding this comment

Uh oh!

sftim Aug 16, 2022

Choose a reason for hiding this comment

Uh oh!

ravisantoshgudimetla Aug 16, 2022

Choose a reason for hiding this comment

Uh oh!

marosset commented Aug 15, 2022

Uh oh!

jihoon-seo commented Aug 16, 2022

Uh oh!

ravisantoshgudimetla commented Aug 16, 2022

Uh oh!

ravisantoshgudimetla commented Aug 16, 2022

Uh oh!

bradtopol commented Aug 16, 2022

Uh oh!

marosset commented Aug 17, 2022

Uh oh!

jihoon-seo commented Aug 19, 2022

Uh oh!

sftim commented Aug 19, 2022

Uh oh!

reylejano commented Aug 22, 2022

Uh oh!

k8s-ci-robot commented Aug 22, 2022

Uh oh!

sftim commented Aug 22, 2022

Uh oh!

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Aug 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

netlify bot commented Aug 15, 2022 •

edited

Loading

marosset Aug 15, 2022 •

edited

Loading